FINERACT-405: Add client and staff mobile number validation#5939
Open
anubhavio wants to merge 1 commit into
Open
FINERACT-405: Add client and staff mobile number validation#5939anubhavio wants to merge 1 commit into
anubhavio wants to merge 1 commit into
Conversation
Contributor
Author
|
@adamsaghy Thank you for the review. I pushed a follow-up commit to fix the CI import-order issue. The new workflow runs are currently awaiting approval. |
Contributor
|
@anubhavio Please squash your changes... |
FINERACT-405: Fix import order FINERACT-405: Apply Spotless formatting FINERACT-405: Fix staff integration test for phone validation
anubhavio
force-pushed
the
FINERACT-405-phone-number-validation
branch
from
1ac8c4c to
2358c57
Compare
Contributor
Author
|
@adamsaghy I reviewed the current CI failures. The jobs appear to be failing due to Docker/Maven dependency download issues rather than application test failures. Could you please re-trigger the failed workflows when convenient? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds backend validation for client and staff mobile numbers.
Changes
-Added mobile number validation for client create and update operations.
-Added mobile number validation for staff create and update requests using Jakarta Bean Validation.
-Added validation message for invalid staff mobile numbers.
-Added unit tests covering valid and invalid client mobile number scenarios.
##Notes
This PR focuses on backend validation only. It does not implement default country code handling or phone number normalization.