Skip to content

FINERACT-2630: Use Collection.isEmpty() instead of size() comparison in fineract-savings#5953

Open
heissenberg06 wants to merge 1 commit into
apache:developfrom
heissenberg06:FINERACT-2630-savings-isempty
Open

FINERACT-2630: Use Collection.isEmpty() instead of size() comparison in fineract-savings#5953
heissenberg06 wants to merge 1 commit into
apache:developfrom
heissenberg06:FINERACT-2630-savings-isempty

Conversation

@heissenberg06
Copy link
Copy Markdown
Contributor

@heissenberg06 heissenberg06 commented Jun 7, 2026

Description

Replaces 6 occurrences of Collection.size() > 0 emptiness checks with !Collection.isEmpty() across the fineract-savings module (SavingsAccount, SavingsAccountRepositoryWrapper, SavingsSchedularInterestPoster), as flagged by SonarCloud rule java:S1155 ("Collection.isEmpty() should be used to test for emptiness"). This mirrors the cleanup done for the fineract-loan module in FINERACT-2627.

The change is behavior-preserving — !collection.isEmpty() is equivalent to collection.size() > 0 — and is a readability/consistency cleanup only. No API, schema, or functional behavior changes. JsonArray checks and index-bound size() usages were intentionally left untouched. Covered by existing tests.

JIRA: https://issues.apache.org/jira/browse/FINERACT-2630

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

Copy link
Copy Markdown
Contributor

@adamsaghy adamsaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants