Skip to content

FINERACT-2632: Add missing fields to Clients Swagger spec for type-safe Feign client generation#5955

Merged
adamsaghy merged 1 commit into
apache:developfrom
DeathGun44:FINERACT-2632/client-swagger-spec-fix
Jun 8, 2026
Merged

FINERACT-2632: Add missing fields to Clients Swagger spec for type-safe Feign client generation#5955
adamsaghy merged 1 commit into
apache:developfrom
DeathGun44:FINERACT-2632/client-swagger-spec-fix

Conversation

@DeathGun44
Copy link
Copy Markdown
Contributor

@DeathGun44 DeathGun44 commented Jun 7, 2026

Description

Adds missing fields to PostClientsRequest (submittedOnDate), PostClientsClientIdRequest (withdrawalDate, withdrawalReasonId, reopenedDate), and PutClientsClientIdRequest (firstname, lastname) so the generated Feign client models match what the server actually accepts.

Blocks: FINERACT-2631

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

…fe Feign client generation

Signed-off-by: DeathGun44 <krishnamewara841@gmail.com>
@DeathGun44
Copy link
Copy Markdown
Contributor Author

the test just timed out ,re-running should make it pass

@adamsaghy adamsaghy merged commit 4834786 into apache:develop Jun 8, 2026
179 of 180 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants