FINERACT-1788: Replace notification native queries with JPQL#5956
Open
udayagiri-sivasai-dev wants to merge 1 commit into
Open
FINERACT-1788: Replace notification native queries with JPQL#5956udayagiri-sivasai-dev wants to merge 1 commit into
udayagiri-sivasai-dev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses FINERACT-1788 by replacing native SQL/JdbcTemplate usage in the Notifications read platform service with Spring Data JPA/JPQL repository methods.
Changes made:
NotificationMapperRepository.NotificationData.JdbcTemplate,RowMapper, and native SQL query code fromNotificationReadPlatformServiceImpl.NotificationConfigurationconstructor wiring after removing old JDBC dependencies.Validation performed:
spotlessApply.:fineract-provider:compileJavasuccessfully.JdbcTemplate,RowMapper,nativeQuery,createNativeQuery, orString sqlusage remains in the notification module.git diff --check.