FINERACT-809 Upgrade rest-assured version#677
FINERACT-809 Upgrade rest-assured version#677percyashu wants to merge 2 commits intoapache:developfrom
Conversation
|
@awasum or @vorburger I also need some help with this issue. |
|
Please.. @percyashu , its usually a good idea to finish one task completely and its merged before you move on to the next one. This is good work BTW. So focus on one..Try Googling your error and fix it. I will look at your PRs tomorrow. |
|
@awasum, Ok will keep searching for a solution. |
There was a problem hiding this comment.
This line doesn't seem right, to me... we only want rest-assured to be test scoped dependency, not a runtime dependency (i.e. it should never be part of the WAR) - agreed? Would you like to remove it? I doubt it will help with that (strange!) NoClassDefFoundError, but IMHO it's still worth a try, as a first step.
There was a problem hiding this comment.
I was trying to get rid NoClassDefFoundError that's why I placed it there.
There was a problem hiding this comment.
as above, I would suggest to remove this (and only testCompile it)
| compile 'io.rest-assured:rest-assured' |
There was a problem hiding this comment.
Ok I will remove it.
percyashu
force-pushed
the
FINERACT-809
branch
from
c5b3aac to
3ec787f
Compare
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
|
@percyashu Please..make sure you complete 1 issue before moving to the next one. THere is no point opening more than 1 PR at a time and try to work on all at same time. In general, thats usually a bad idea especially for new programmers. Finish one, then pick another and you find that you make more progress that way. Leave the other PRs you have opened like that and take one of them to fix before moving to the next. |
|
@percyashu you can close this now since it has already been resolved in another PR |
|
==> #719 |
4 participants
Description
Upgrade rest-assured to latest spring boot compatible version https://issues.apache.org/jira/browse/FINERACT-809
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
Integration tests have been created/updated for verifying the changes made.
All Integrations tests are passing with the new commits.
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide