throw exception with details in InteropServiceImpl (FINERACT-860)#728
Merged
awasum merged 1 commit intoapache:developfrom Mar 10, 2020
Merged
Conversation
instead of the NoSuchElementException from Optional.get(), we're now throwing an UnsupportedOperationException which includes the details of the missing object. (This kind of detailed exception was already thrown in two existing places in the same code after a null check, but it never reached there, because the Optional.get() failed earlier. Another option would have been to return null for an absent Optional, but this is better.) The other unrelated changes are automatic clean up actions (in Eclipse).
Member
Author
|
@awasum want to review this one? See the JIRA for some background. |
awasum
approved these changes
Mar 10, 2020
Contributor
awasum
left a comment
awasum
left a comment
There was a problem hiding this comment.
LGTM. Merging now. Thanks @vorburger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instead of the NoSuchElementException from Optional.get(), we're now
throwing an UnsupportedOperationException which includes the details of
the missing object. (This kind of detailed exception was already thrown
in two existing places in the same code after a null check, but it never
reached there, because the Optional.get() failed earlier. Another
option would have been to return null for an absent Optional, but this
is better.)
The other unrelated changes are automatic clean up actions (in Eclipse).
see https://issues.apache.org/jira/projects/FINERACT/issues/FINERACT-860