FINERACT-111 Do not update charges amount paid if loan transaction is accruals#741
Merged
vorburger merged 1 commit intoapache:developfrom Apr 26, 2020
Merged
Conversation
Contributor
|
This needs functional review, @emmanuelnnaa please can you check this. |
vorburger
added
the
Needs Functional Review
Member
|
@emmanuelnnaa can you confirm this is good to merge? @xurror can you ping someone to confirm? @awasum do you know anyone we can get to sign off on this? Otherwise I suggest we just merge it in 2 weeks, based on "trust". |
Contributor
I don't know. maybe @nazeer1100126 , @vishwasbabu or @avikganguly01 can help us?
Fine with me |
Member
|
Nobody seems to be willing to step up for functional testing, so I'm just merging this.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I found this issue with a small task, I am not sure about the background this needs to be verified.
https://issues.apache.org/jira/projects/FINERACT/issues/FINERACT-111?filter=allopenissues
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
Integration tests have been created/updated for verifying the changes made.
All Integrations tests are passing with the new commits.
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide