add new testNumberOfJobs() to SchedulerJobsTest (re. FINERACT-922)#821
Merged
vorburger merged 2 commits intoapache:developfrom May 17, 2020
Merged
Conversation
Member
Author
|
Failed due to |
vorburger
force-pushed
the
FINERACT-922_SchedulerJobsTest_testNumberOfJobs
branch
2 times, most recently
from
8b03c36 to
f1b70fe
Compare
This would catch problems such as the integration tests running "too early" (before Flyway has fully initialized the database), which I have a suspicion could be one of (many) causes of the unstable scheduler tests, notably because of the IllegalArgumentException at SchedulerJobsTest.java:90 in apache#817
vorburger
force-pushed
the
FINERACT-922_SchedulerJobsTest_testNumberOfJobs
branch
from
f1b70fe to
3350d48
Compare
Member
Author
Contributor
|
Looks good to me! |
Contributor
|
Couldn't help but notice references to 2 different issues in your commits. Changes are very little though. I don't know if they are co-dependent but would have been much better to raise 2 different PRs for each of them. But as I said, very little changes so, I don't mind if you merge it like this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will catch problems such as the integration tests running "too early" (before Flyway has fully initialized the database), which I have a suspicion could be one of (many) causes of the unstable scheduler tests, notably because of the IllegalArgumentException at SchedulerJobsTest.java:90 in #817.
see FINERACT-922 and FINERACT-952 re. removed JobName