rewrite MultiException to actually contain all causes (FINERACT-858)#855
Merged
awasum merged 1 commit intoapache:developfrom May 15, 2020
Merged
Conversation
Member
Author
|
@ptuomola how do you like this? |
vorburger
force-pushed
the
FINERACT-858_MultiException
branch
from
5a4387f to
a28d931
Compare
Member
Author
@ptuomola and now this actually even builds green 😺 @maektwain @awasum @xurror anyone else review this - LGTY? |
Member
Author
|
It sounds like nobody seems to have any strong objections to this one, so I'd like to "self merge" it tomorrow. |
Contributor
|
Looks good to me - much cleaner than the previous code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FINERACT-858, useful for debugging FINERACT-922