Skip to content

copy .git/** into build container so git.properties can be generated [FINERACT-983]#904

Merged
awasum merged 1 commit intoapache:developfrom
vorburger:FINERACT-983_container_git.properties
May 17, 2020
Merged

copy .git/** into build container so git.properties can be generated [FINERACT-983]#904
awasum merged 1 commit intoapache:developfrom
vorburger:FINERACT-983_container_git.properties

Conversation

@vorburger
Copy link
Member

read details in FINERACT-983

@vorburger
Copy link
Member Author

@xurror @ptuomola @awasum check this out.. do you have any better ideas? Merge?

Copy link
Contributor

@xurror xurror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@vorburger
Copy link
Member Author

@awasum Is this OK for you too?

@vorburger
Copy link
Member Author

@ptuomola no objections to this? See linked JIRA. If @awasum or @xurror merge this ASAP, then I'll send an email to the dev list to announce the auto-updating of fineract.dev, which finally fully works end2end, since yesterday! I'd love this to be merged before I announce, because this change helps to "see" what's actually running on Fineract.dev.

@ptuomola
Copy link
Contributor

Looks good - except the previous comment that copying .git slows things down, and that is why it was excluded. Is that no longer the case - ie do we not end up with the same issue now that we are again including .git? It's basically copying the entire repository history, right?

@awasum
Copy link
Contributor

awasum commented May 17, 2020

Can we get the CI system to copy just the latest revision of the history? Will that help?
Like:
git clone -–depth [depth] [remote-url]

@awasum
Copy link
Contributor

awasum commented May 17, 2020

Maybe we do this in a follow up PR? Or even rethink the issue of adding latest git revision in /actuator/info... IS there a better way?

@awasum
Copy link
Contributor

awasum commented May 17, 2020

I will merge this and someone can cycle back to this in the near future.

@awasum awasum merged commit e7889f8 into apache:develop May 17, 2020
@vorburger
Copy link
Member Author

https://demo.fineract.dev/fineract-provider/actuator/info - yay!! (This was fully automated.)

@ptuomola @awasum see my comments in FINERACT-983 and FINERACT-911 re. your points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants