FINERACT-821 Added and Enforced Typename checkstyle#920
Merged
vorburger merged 1 commit intoapache:developfrom May 22, 2020
Merged
FINERACT-821 Added and Enforced Typename checkstyle#920vorburger merged 1 commit intoapache:developfrom
vorburger merged 1 commit intoapache:developfrom
Conversation
thesmallstar
force-pushed
the
checkstyle-typename
branch
from
837f549 to
f2014f6
Compare
Member
@thesmallstar you can use Mark as Draft (on the right) to "signal" that a PR is Work-In-Progress (WIP) |
thesmallstar
force-pushed
the
checkstyle-typename
branch
from
f2014f6 to
46298ae
Compare
Member
Author
|
@vorburger ready for your review. |
xurror
approved these changes
May 22, 2020
Contributor
xurror
left a comment
xurror
left a comment
There was a problem hiding this comment.
That's alot of files to changes. Great work on this one. LGTM
Member
|
@thesmallstar resolve merge conflicts please |
thesmallstar
force-pushed
the
checkstyle-typename
branch
from
46298ae to
3f8fc18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer: https://issues.apache.org/jira/browse/FINERACT-821
Needs a rebase, please do not merge this I will review this once again before any of the mentors can take a look :)