replace iText with openPDF [FINERACT-965]#948
Conversation
|
@xurror @awasum would you like to review and merge this? based on and extending @nnatarajan #940 |
fda5d38 to
e558836
Compare
...c/main/java/org/apache/fineract/infrastructure/documentmanagement/api/ImagesApiResource.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/fineract/infrastructure/documentmanagement/api/ImagesApiResource.java
Outdated
Show resolved
Hide resolved
e558836 to
2ae75f8
Compare
|
Build failed because of this: org.apache.fineract.integrationtests.ClientLoanIntegrationTest > testLoanRefundByCashCashBasedAccounting FAILED I've faced a couple of those locally too. Thought it was maybe related to some setting on my PC, but this could really be a problem. |
|
It's awesome that you want to use OpenPDF. Let me know if you need any changes in OpenPDF. I am one of the OpenPDF maintainers. |
|
/rebase The flaky test is "just" due to what @ptuomola documented in FINERACT-885 (nice find!) @andreasrosdal great to hear from you! Thank You very very much for maintaining OpenPDF. |
2ae75f8 to
1085666
Compare
|
This is now failing an integration test because of the changes I made here (not flaky), still something with that Base64 change... I haven't been able to entirely understand it - yet. If someone reading along "sees" the problem, please comment, else I'll dig further to figure it out... |
|
Oh, it's because of |
and replace com.lowagie.text.pdf.codec.Base64 with java.util.Base64
1085666 to
6ab86e3
Compare
|
@xurror do you want to re-review this, and if OK, click Rebase and Merge? |
FINERACT-965