Skip to content

replace iText with openPDF [FINERACT-965]#948

Merged
xurror merged 4 commits intoapache:developfrom
vorburger:NN_FINERACT-965
Jun 2, 2020
Merged

replace iText with openPDF [FINERACT-965]#948
xurror merged 4 commits intoapache:developfrom
vorburger:NN_FINERACT-965

Conversation

@vorburger
Copy link
Member

@vorburger vorburger commented May 28, 2020

@vorburger
Copy link
Member Author

@xurror @awasum would you like to review and merge this?

based on and extending @nnatarajan #940

@vorburger
Copy link
Member Author

@fynmanoj @xurror better now? 😸 Go Ahead and Merge if OK. Thanks again for spotting that.

@xurror
Copy link
Contributor

xurror commented May 31, 2020

Build failed because of this:
`org.apache.fineract.integrationtests.FixedDepositTest > testFixedDepositAccountClosureTypeWithdrawal_WITH_HOLD_TAX SKIPPED

org.apache.fineract.integrationtests.ClientLoanIntegrationTest > testLoanRefundByCashCashBasedAccounting FAILED

java.lang.AssertionError: 1 expectation failed.

Expected status code <200> but was <403>.

    at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)

    at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)

    at `

I've faced a couple of those locally too. Thought it was maybe related to some setting on my PC, but this could really be a problem.

@xurror xurror closed this May 31, 2020
@xurror xurror reopened this May 31, 2020
@andreasrosdalw
Copy link

It's awesome that you want to use OpenPDF. Let me know if you need any changes in OpenPDF. I am one of the OpenPDF maintainers.

@vorburger
Copy link
Member Author

/rebase

The flaky test is "just" due to what @ptuomola documented in FINERACT-885 (nice find!)

@andreasrosdal great to hear from you! Thank You very very much for maintaining OpenPDF.

@vorburger
Copy link
Member Author

This is now failing an integration test because of the changes I made here (not flaky), still something with that Base64 change... I haven't been able to entirely understand it - yet. If someone reading along "sees" the problem, please comment, else I'll dig further to figure it out...

@vorburger
Copy link
Member Author

Oh, it's because of java.util.Base64's default VS URL VS MIME variants... I'll fix it. -- BTW: The (failing) StaffImageApiTest really should cover ImagesApiResource.retrieveImage() method as well; I'll try to add that here.

@vorburger
Copy link
Member Author

@xurror do you want to re-review this, and if OK, click Rebase and Merge?

Copy link
Contributor

@xurror xurror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xurror xurror merged commit 956a841 into apache:develop Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants