-
Notifications
You must be signed in to change notification settings - Fork 82
[plan][java] Built-in actions support async execution. #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
hs_err_pid84909.log |
| } | ||
| }); | ||
| } else { | ||
| response = chatModel.chat(messages, Map.of()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we also use durableExecute for the synchronized model calls? Same for the other resources and in python.
|
|
||
| boolean chatAsync = ctx.getConfig().get(AgentExecutionOptions.CHAT_ASYNC); | ||
| // TODO: python chat model doesn't support async execution yet. | ||
| chatAsync = chatAsync && !(chatModel instanceof PythonChatModelSetup); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to point to an issue that describes and tracks the problem blocking python chat model from supporting async execution.
c4d93b1 to
f27f4a5
Compare
f27f4a5 to
01273e3
Compare
xintongsong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Linked issue: #381
Purpose of change
Support async execution for java built-in actions
Tests
e2e
API
Documentation
doc-neededdoc-not-neededdoc-included