Skip to content

Conversation

@wenjin272
Copy link
Collaborator

@wenjin272 wenjin272 commented Jan 16, 2026

Linked issue: #381

Purpose of change

Support async execution for java built-in actions

Tests

e2e

API

Documentation

  • doc-needed
  • doc-not-needed
  • doc-included

@github-actions github-actions bot added priority/major Default priority of the PR or issue. fixVersion/0.2.0 The feature or bug should be implemented/fixed in the 0.2.0 version. doc-needed Your PR changes impact docs. labels Jan 16, 2026
@wenjin272
Copy link
Collaborator Author

wenjin272 commented Jan 16, 2026

hs_err_pid84909.log
Async execution for PythonChatModelSetup will cause jvm crash, so the async execution for cross language resources is disabled.

@wenjin272 wenjin272 requested a review from xintongsong January 16, 2026 15:10
}
});
} else {
response = chatModel.chat(messages, Map.of());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we also use durableExecute for the synchronized model calls? Same for the other resources and in python.


boolean chatAsync = ctx.getConfig().get(AgentExecutionOptions.CHAT_ASYNC);
// TODO: python chat model doesn't support async execution yet.
chatAsync = chatAsync && !(chatModel instanceof PythonChatModelSetup);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to point to an issue that describes and tracks the problem blocking python chat model from supporting async execution.

@wenjin272 wenjin272 force-pushed the built-in-async-java branch 2 times, most recently from c4d93b1 to f27f4a5 Compare January 17, 2026 11:53
@wenjin272 wenjin272 force-pushed the built-in-async-java branch from f27f4a5 to 01273e3 Compare January 17, 2026 12:16
Copy link
Contributor

@xintongsong xintongsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xintongsong xintongsong merged commit e0801a0 into apache:main Jan 17, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-needed Your PR changes impact docs. fixVersion/0.2.0 The feature or bug should be implemented/fixed in the 0.2.0 version. priority/major Default priority of the PR or issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants