-
Notifications
You must be signed in to change notification settings - Fork 83
[doc] Add documents for adding dependencies to flink-agents project. #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5872828 to
3897ac2
Compare
| </parent> | ||
|
|
||
| <artifactId>flink-agents-ide-support</artifactId> | ||
| <name>Flink Agents : IDE Support</name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a <description> here to explain what this artifact is for. Otherwise, it's a bit implicit.
|
|
||
| **Required for developing Agent applications:** | ||
| - `flink-agents-api` - Core API for Flink-Agents | ||
| - `flink-streaming-java` and `flink-table-api-java` - Core API for Flink |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - `flink-streaming-java` and `flink-table-api-java` - Core API for Flink | |
| - `flink-streaming-java` and/or `flink-table-api-java` - Core API for Flink |
|
|
||
| **Additional dependencies for running in IDE:** | ||
| - `flink-agents-ide-support` - Runtime execution dependencies (required for local execution/testing). | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use "required" vs. "optional" here.
We should explain that, unlike running in a Flink cluster, when running in IDE, runtime dependencies are absent, so we need this additional dependency, and use "run with provided dependencies" feature of IDE.
And we should emphasis to use provided scope.
…flink-agents in IDE.
Co-authored-by: Shekharrajak <shekharrajak@live.com>
Linked issue: #393
Purpose of change
flink-agents-runtime-bundlemodule to decrease the complexity for users to introduce execution dependencies in flink-agents project.Tests
No
API
No
Documentation
doc-neededdoc-not-neededdoc-included