Skip to content

[Feature][Java] Add java event listeners config#641

Merged
wenjin272 merged 6 commits into
apache:mainfrom
twosom:add_java_event_listeners_config
May 15, 2026
Merged

[Feature][Java] Add java event listeners config#641
wenjin272 merged 6 commits into
apache:mainfrom
twosom:add_java_event_listeners_config

Conversation

@twosom
Copy link
Copy Markdown
Contributor

@twosom twosom commented Apr 25, 2026

Linked issue: #640

Purpose of change

Added event listeners config in java

Tests

ok

API

Documentation

  • doc-needed
  • doc-not-needed
  • doc-included

@github-actions github-actions Bot added doc-needed Your PR changes impact docs. fixVersion/0.3.0 The feature or bug should be implemented/fixed in the 0.3.0 version. priority/major Default priority of the PR or issue. labels Apr 25, 2026
Copy link
Copy Markdown
Collaborator

@wenjin272 wenjin272 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @twosom. Overall looks good to me. I left two minor comments.

Comment thread api/src/main/java/org/apache/flink/agents/api/listener/EventListener.java Outdated
@twosom
Copy link
Copy Markdown
Contributor Author

twosom commented May 2, 2026

Thanks for your contribution, @twosom. Overall looks good to me. I left two minor comments.

Thanks for the review! @wenjin272
I’ve applied both minor suggestions!
Please take another look when you have a moment. Thanks!

Copy link
Copy Markdown
Collaborator

@wenjin272 wenjin272 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but there are some conflicts with main branch need resolve.

@twosom twosom force-pushed the add_java_event_listeners_config branch from ac38516 to ac22b2b Compare May 14, 2026 08:14
twosom and others added 6 commits May 14, 2026 17:15
# Conflicts:
#	api/src/main/java/org/apache/flink/agents/api/configuration/AgentConfigOptions.java
- Move notifyEventProcessed to the start of processEvent to ensure consistency with documentation.
- Update EventListener Javadoc to clarify that listeners are notified when an event is received.
# Conflicts:
#	runtime/src/main/java/org/apache/flink/agents/runtime/operator/EventRouter.java
@twosom twosom force-pushed the add_java_event_listeners_config branch from ac22b2b to ff8a32d Compare May 14, 2026 08:22
@twosom
Copy link
Copy Markdown
Contributor Author

twosom commented May 14, 2026

Thanks for the review, @wenjin272!
I've resolved the merge conflicts and updated the branch. Please take another look.

Copy link
Copy Markdown
Collaborator

@wenjin272 wenjin272 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenjin272 wenjin272 merged commit 2cb4fb0 into apache:main May 15, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-needed Your PR changes impact docs. fixVersion/0.3.0 The feature or bug should be implemented/fixed in the 0.3.0 version. priority/major Default priority of the PR or issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants