[hotfix] Remove unused DurableExecutionManager.maybePruneState helper#682
Open
weiqingy wants to merge 1 commit into
Open
[hotfix] Remove unused DurableExecutionManager.maybePruneState helper#682weiqingy wants to merge 1 commit into
weiqingy wants to merge 1 commit into
Conversation
`DurableExecutionManager.maybePruneState(Object, long)` has no production callers and is not part of the `ActionStatePersister` interface — only a single test method references it. It is a leftover from the apache#546 refactor. Timeline (from `git log -S "maybePruneState"`): - apache#138 introduced `maybePruneState(...)` as a `private` helper on `ActionExecutionOperator`, called from the per-key completion path: `maybePruneState(key, sequenceNumber);`. - apache#603 ("Fix prune state corner cases around checkpoints") deliberately removed both the call site and the helper. The fix moved pruning from the per-key path to the checkpoint-driven path inside `notifyCheckpointComplete`, where it now prunes using `lastCompletedSequenceNumber` captured at the checkpoint barrier via `snapshotLastCompletedSequenceNumbers`. That is the current/correct architecture. - apache#546 ("Refactor ActionExecutionOperator into focused manager classes") extracted `DurableExecutionManager` and re-surfaced `maybePruneState(...)` on the new class — but no caller was re-added, correctly so. This commit removes the orphan. Changes: - Delete `DurableExecutionManager.maybePruneState(Object, long)`. - Drop the `dem.maybePruneState("k", 0L);` line from the existing `noStoreModeMakesAllMaybeOperationsNoOp` no-op coverage test. The remaining `maybe*` no-op assertions still cover the null-store invariant for every `maybe*` method on the class today.
github-actions
Bot
added
doc-not-needed
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DurableExecutionManager.maybePruneState(Object, long)has no production callers and is not part of theActionStatePersisterinterface — only a single test method references it. It is a leftover from the #546 refactor.Timeline (from
git log -S "maybePruneState"):maybePruneState(...)as aprivatehelper onActionExecutionOperator, called from the per-key completion path:maybePruneState(key, sequenceNumber);.notifyCheckpointComplete, where it now prunes usinglastCompletedSequenceNumbercaptured at the checkpoint barrier viasnapshotLastCompletedSequenceNumbers. That is the current/correct architecture.DurableExecutionManagerand re-surfacedmaybePruneState(...)on the new class — but no caller was re-added, correctly so. This commit removes the orphan.Changes:
DurableExecutionManager.maybePruneState(Object, long).dem.maybePruneState("k", 0L);line from the existingnoStoreModeMakesAllMaybeOperationsNoOpno-op coverage test. The remainingmaybe*no-op assertions still cover the null-store invariant for everymaybe*method on the class today.Documentation
doc-neededdoc-not-neededdoc-included