[fix] Reject parameter_types on Python YAML tools (#774)#804
Merged
Conversation
The YAML loader documented parameter_types as java-only/forbidden for Python tools, but only validated the java-missing direction. A Python tool declaring parameter_types passed through and was silently dropped. Add a fail-fast check and align the ToolSpec docstring with the doc. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
doc-included
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue: #774
Purpose of change
The YAML loader documented parameter_types as java-only/forbidden for Python tools, but only validated the java-missing direction. A Python tool declaring parameter_types passed through and was silently dropped. Add a fail-fast check and align the ToolSpec docstring with the doc.
Tests
ut
API
no
Documentation
doc-neededdoc-not-neededdoc-included