Skip to content

feat[vitess]: Update connector properties for debezium-1.9.7#2260

Merged
GOODBOY008 merged 4 commits intoapache:masterfrom
vinted:feat/vitess/update-connector-properties
Jul 22, 2023
Merged

feat[vitess]: Update connector properties for debezium-1.9.7#2260
GOODBOY008 merged 4 commits intoapache:masterfrom
vinted:feat/vitess/update-connector-properties

Conversation

@s-gelazevicius
Copy link
Copy Markdown
Contributor

@s-gelazevicius s-gelazevicius commented Jul 3, 2023 •
edited
Loading

After debezium upgrade some optional vitess config parameters where added and some removed.
Making config parameters up to date with the latest supported debezium version: 1.9.7

@s-gelazevicius s-gelazevicius force-pushed the feat/vitess/update-connector-properties branch 2 times, most recently from 7aede0c to e7a85cd Compare July 3, 2023 14:35
@ruanhang1993 ruanhang1993 modified the milestones: V2.5.0, V2.4.1 Jul 6, 2023
ruanhang1993
ruanhang1993 reviewed Jul 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@ruanhang1993 ruanhang1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s-gelazevicius Thanks for changes. I left some comments.

Please update the docs for these new options.

Comment thread ...r-vitess-cdc/src/main/java/com/ververica/cdc/connectors/vitess/table/VitessTableFactory.java Outdated
Comment thread ...or-vitess-cdc/src/main/java/com/ververica/cdc/connectors/vitess/table/VitessTableSource.java Outdated
Comment thread ...or-vitess-cdc/src/main/java/com/ververica/cdc/connectors/vitess/table/VitessTableSource.java Outdated
Comment thread ...or-vitess-cdc/src/main/java/com/ververica/cdc/connectors/vitess/table/VitessTableSource.java Outdated
Comment thread ...or-vitess-cdc/src/main/java/com/ververica/cdc/connectors/vitess/table/VitessTableSource.java Outdated
Comment thread ...or-vitess-cdc/src/main/java/com/ververica/cdc/connectors/vitess/table/VitessTableSource.java Outdated
@GOODBOY008 GOODBOY008 self-requested a review July 7, 2023 03:22
@s-gelazevicius s-gelazevicius force-pushed the feat/vitess/update-connector-properties branch from e7a85cd to 756b194 Compare July 10, 2023 09:55
@gtk96
Copy link
Copy Markdown
Contributor

gtk96 commented Jul 18, 2023

image

docs there are some display anomalies, as shown above, can this be fixed together?

The redundant characters cause problems with the display after the page is built.

image

@GOODBOY008
Copy link
Copy Markdown
Member

GOODBOY008 commented Jul 18, 2023

image docs there are some display anomalies, as shown above, can this be fixed together?

The redundant characters cause problems with the display after the page is built.

image

@gtk96 https://github.com/ververica/flink-cdc-connectors/blob/fc5188f5f35a329695ea2bee0df59e88545532e1/docs/content/connectors/vitess-cdc.md It looks well , do you use latest code?

@gtk96
Copy link
Copy Markdown
Contributor

gtk96 commented Jul 18, 2023

image docs there are some display anomalies, as shown above, can this be fixed together? The redundant characters cause problems with the display after the page is built. image

@gtk96 https://github.com/ververica/flink-cdc-connectors/blob/fc5188f5f35a329695ea2bee0df59e88545532e1/docs/content/connectors/vitess-cdc.md It looks well , do you use latest code?

There will be problems when converting to an html page.

https://ververica.github.io/flink-cdc-connectors/master/content/connectors/vitess-cdc.html#connector-options

image

@GOODBOY008
Copy link
Copy Markdown
Member

GOODBOY008 commented Jul 18, 2023 •
edited
Loading

@s-gelazevicius You should remove useless “ and &rdquo characters in docs/content/connectors/vitess-cdc.md.
}@}353F4~KBZ0N8V5AU)KQM

GOODBOY008
GOODBOY008 reviewed Jul 19, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s-gelazevicius Please fix docs/content/connectors/vitess-cdc.md.

@ruanhang1993 ruanhang1993 removed this from the V2.4.1 milestone Jul 19, 2023
gtk96
gtk96 reviewed Jul 20, 2023
View reviewed changes
Comment thread docs/content/connectors/vitess-cdc.md Outdated
@s-gelazevicius s-gelazevicius requested a review from gtk96 July 21, 2023 09:20
gtk96
gtk96 approved these changes Jul 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@gtk96 gtk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @s-gelazevicius LGTM

GOODBOY008
GOODBOY008 approved these changes Jul 22, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GOODBOY008 GOODBOY008 merged commit 2cf3723 into apache:master Jul 22, 2023
@s-gelazevicius s-gelazevicius deleted the feat/vitess/update-connector-properties branch August 23, 2023 08:18
GOODBOY008 pushed a commit to GOODBOY008/flink-cdc that referenced this pull request Oct 30, 2023
@s-gelazevicius @GOODBOY008
[vitess] Migrate connector properties to debezium 1.9.7 (apache#2260)
2b5e9f8 
* feat[vitess]: Update connector properties for debezium-1.9.7

* fix: Address review comments

* fix: remove useless &ldquo and &rdquo

* fix: remove useless &nbsp

(cherry picked from commit 2cf3723)
@GOODBOY008 GOODBOY008 mentioned this pull request Oct 30, 2023
Merged
GOODBOY008 pushed a commit to GOODBOY008/flink-cdc that referenced this pull request Oct 30, 2023
@s-gelazevicius @GOODBOY008
[vitess] Migrate connector properties to debezium 1.9.7 (apache#2260)
082f157 
* feat[vitess]: Update connector properties for debezium-1.9.7

* fix: Address review comments

* fix: remove useless &ldquo and &rdquo

* fix: remove useless &nbsp

(cherry picked from commit 2cf3723)
GOODBOY008 pushed a commit to GOODBOY008/flink-cdc that referenced this pull request Oct 31, 2023
@s-gelazevicius @GOODBOY008
[vitess] Migrate connector properties to debezium 1.9.7 (apache#2260)
7ee8da7 
* feat[vitess]: Update connector properties for debezium-1.9.7

* fix: Address review comments

* fix: remove useless &ldquo and &rdquo

* fix: remove useless &nbsp

(cherry picked from commit 2cf3723)
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
@s-gelazevicius @ChaomingZhangCN
[vitess] Migrate connector properties to debezium 1.9.7 (apache#2260)
3fd2003 
* feat[vitess]: Update connector properties for debezium-1.9.7

* fix: Address review comments

* fix: remove useless &ldquo and &rdquo

* fix: remove useless &nbsp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GOODBOY008 GOODBOY008 GOODBOY008 approved these changes

@ruanhang1993 ruanhang1993 ruanhang1993 approved these changes

+1 more reviewer

@gtk96 gtk96 gtk96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@s-gelazevicius @gtk96 @GOODBOY008 @ruanhang1993