[mongodb] Add disableCursorTimeout option, addresses #2302#2332
Merged
Jiabao-Sun merged 1 commit intoapache:masterfrom Jul 24, 2023
Merged
[mongodb] Add disableCursorTimeout option, addresses #2302#2332Jiabao-Sun merged 1 commit intoapache:masterfrom
disableCursorTimeout option, addresses #2302#2332Jiabao-Sun merged 1 commit intoapache:masterfrom
Conversation
Member
Author
|
Haven't added it into Table API since I noticed that DataSource API seems to have more "hidden" (undocumented) options than Table API. Plus, this option only takes into effect if |
2 tasks
yuxiqian
force-pushed
the
mongo/cursor-timeout-config
branch
3 times, most recently
from
b3de4dc to
1f59e64
Compare
Member
Author
|
Could @Jiabao-Sun help reviewing it? |
Contributor
|
Thanks @yuxiqian for this enhancement. |
yuxiqian
force-pushed
the
mongo/cursor-timeout-config
branch
from
1f59e64 to
0f90eae
Compare
Member
Author
|
Added. Picked name |
Jiabao-Sun
approved these changes
Jul 24, 2023
Contributor
Jiabao-Sun
left a comment
Jiabao-Sun
left a comment
There was a problem hiding this comment.
Thanks @yuxiqian for the updates. LGTM.
GOODBOY008
pushed a commit
to GOODBOY008/flink-cdc
that referenced
this pull request
Oct 30, 2023
(cherry picked from commit a8dd4d3)
GOODBOY008
pushed a commit
to GOODBOY008/flink-cdc
that referenced
this pull request
Oct 30, 2023
(cherry picked from commit a8dd4d3)
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #2302.
Currently, MongoDB CDC uses
noCursorTimeoutoption when performing incremental snapshot. However, some MongoDB server doesn't support creating cursor with unlimited timeout.To address this issue, an option
disableCursorTimeoutwas added inmongodb.source.MongoDBSource(but not its legacy counterpartmongodb.MongoDBSourcesince it isn't affected).