Skip to content

[docs] Add contribution guidance section in document#2411

Merged
ruanhang1993 merged 1 commit intoapache:masterfrom
gtk96:contribute_guidance
Aug 23, 2023
Merged

[docs] Add contribution guidance section in document#2411
ruanhang1993 merged 1 commit intoapache:masterfrom
gtk96:contribute_guidance

Conversation

@gtk96
Copy link
Copy Markdown
Contributor

@gtk96 gtk96 commented Aug 18, 2023

fix #345

@gtk96
Copy link
Copy Markdown
Contributor Author

gtk96 commented Aug 18, 2023

@gtk96 gtk96 force-pushed the contribute_guidance branch 2 times, most recently from a264ae2 to b78876c Compare August 18, 2023 07:58
Comment thread docs/content/about.md Outdated
Comment thread docs/content/about.md Outdated
Comment thread docs/content/about.md
Comment thread docs/content/about.md Outdated
Comment thread docs/content/about.md Outdated
Comment thread docs/content/about.md Outdated
Comment thread docs/content/about.md Outdated
Comment thread docs/content/about.md Outdated
Comment thread docs/content/about.md Outdated
Comment thread docs/content/about.md Outdated
@gtk96 gtk96 force-pushed the contribute_guidance branch from b78876c to bf01173 Compare August 22, 2023 03:46
@gtk96
Copy link
Copy Markdown
Contributor Author

gtk96 commented Aug 22, 2023

@ruanhang1993 Thank you for the very detailed review. I have revised it according to the review comments.

@gtk96 gtk96 requested a review from ruanhang1993 August 22, 2023 07:50
Comment thread docs/content/about.md Outdated
Comment thread docs/content/about.md Outdated
Comment thread docs/content/about.md Outdated
Comment thread docs/content/about.md Outdated
Comment thread docs/content/about.md Outdated
Comment thread docs/content/about.md Outdated
Comment thread docs/content/about.md Outdated
Comment thread docs/content/about.md Outdated
Comment thread docs/content/about.md Outdated
@gtk96 gtk96 force-pushed the contribute_guidance branch from bf01173 to 6d46416 Compare August 22, 2023 08:46
@gtk96 gtk96 requested a review from ruanhang1993 August 22, 2023 09:03
Comment thread docs/content/about.md Outdated
@gtk96 gtk96 force-pushed the contribute_guidance branch from 6d46416 to 5fdda6f Compare August 22, 2023 10:46
@gtk96 gtk96 requested a review from ruanhang1993 August 22, 2023 10:46
Copy link
Copy Markdown
Contributor

@ruanhang1993 ruanhang1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGtM.

@ruanhang1993 ruanhang1993 merged commit 58136b9 into apache:master Aug 23, 2023
@lvyanquan
Copy link
Copy Markdown
Contributor

lvyanquan commented Sep 19, 2023

Hi, looks like check_branch has some mistakes.
https://ververica.github.io/flink-cdc-connectors/master/content/about.html#building-from-source

截屏2023-09-19 上午10 51 55

@gtk96
Copy link
Copy Markdown
Contributor Author

gtk96 commented Sep 21, 2023

Hi, looks like check_branch has some mistakes. https://ververica.github.io/flink-cdc-connectors/master/content/about.html#building-from-source

截屏2023-09-19 上午10 51 55

I will fix it.

@gtk96 gtk96 deleted the contribute_guidance branch September 21, 2023 01:51
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
Co-authored-by: gaotingkai <rookiegao712@gmail>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[docs] Add contribution guidance section in document

4 participants