Skip to content

[debezium] Improve convertToBinary for RowDataDebeziumDeserializeSchema#2435

Merged
leonardBang merged 4 commits intoapache:masterfrom
gong:flink-cdc-improve-convertToBinary
Dec 2, 2023
Merged

[debezium] Improve convertToBinary for RowDataDebeziumDeserializeSchema#2435
leonardBang merged 4 commits intoapache:masterfrom
gong:flink-cdc-improve-convertToBinary

Conversation

@gong
Copy link
Copy Markdown
Contributor

@gong gong commented Aug 28, 2023

dbzObj may be string when mysql cdc set with param 'debezium.binary.handling.mode' = 'base64'.
So add

if (dbzObj instanceof String) {
     String data = (String) dbzObj;
     return data.getBytes(StandardCharsets.UTF_8);
  } 

@gong
Copy link
Copy Markdown
Contributor Author

gong commented Aug 28, 2023

@ruanhang1993 Hello, please help review it.

@gong
Copy link
Copy Markdown
Contributor Author

gong commented Aug 29, 2023

The pipeline is TiDBE2eITCase exception. It is not relative with this PR.

@gong gong force-pushed the flink-cdc-improve-convertToBinary branch from 7d80b63 to 6552a59 Compare December 1, 2023 08:02
@gong
Copy link
Copy Markdown
Contributor Author

gong commented Dec 1, 2023

@leonardBang PTAL

@leonardBang leonardBang self-requested a review December 1, 2023 08:25
Copy link
Copy Markdown
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gong for the contribution, the change looks good to me, could you add a test for this change?

@gong
Copy link
Copy Markdown
Contributor Author

gong commented Dec 1, 2023

Thanks @gong for the contribution, the change looks good to me, could you add a test for this change?
@leonardBang ok. I will add UT.

@gong
Copy link
Copy Markdown
Contributor Author

gong commented Dec 1, 2023

@leonardBang I add an UT.

@gong gong requested a review from leonardBang December 1, 2023 09:52
@gong gong force-pushed the flink-cdc-improve-convertToBinary branch from acef89b to 479d145 Compare December 2, 2023 05:07
Copy link
Copy Markdown
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gong for the explanation and ITCase, the code change part looks good to me.

Could you add parameter 'debezium.binary.handling.mode' = 'base64' to cdc connector option part of docs ? A short paragraph to describe the user case and parameter is recommended

@gong
Copy link
Copy Markdown
Contributor Author

gong commented Dec 2, 2023

Thanks @gong for the explanation and ITCase, the code change part looks good to me.

Could you add parameter 'debezium.binary.handling.mode' = 'base64' to cdc connector option part of docs ? A short paragraph to describe the user case and parameter is recommended

@leonardBang Ok. I will add docs to decribe the user case

@github-actions github-actions Bot added the docs Improvements or additions to documentation label Dec 2, 2023
@gong gong requested a review from leonardBang December 2, 2023 06:32
Copy link
Copy Markdown
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gong for the update, LGTM . Will merge this PR once the CI green

@leonardBang
Copy link
Copy Markdown
Contributor

The failed test is not related to current PR, merging.

@leonardBang leonardBang merged commit 5f31834 into apache:master Dec 2, 2023
@leonardBang leonardBang added this to the V3.0.0 milestone Dec 2, 2023
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation mysql-cdc-connector

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants