[debezium] Improve convertToBinary for RowDataDebeziumDeserializeSchema#2435
Conversation
|
@ruanhang1993 Hello, please help review it. |
|
The pipeline is |
7d80b63 to
6552a59
Compare
|
@leonardBang PTAL |
leonardBang
left a comment
There was a problem hiding this comment.
Thanks @gong for the contribution, the change looks good to me, could you add a test for this change?
|
|
@leonardBang I add an UT. |
acef89b to
479d145
Compare
leonardBang
left a comment
There was a problem hiding this comment.
Thanks @gong for the explanation and ITCase, the code change part looks good to me.
Could you add parameter 'debezium.binary.handling.mode' = 'base64' to cdc connector option part of docs ? A short paragraph to describe the user case and parameter is recommended
@leonardBang Ok. I will add docs to decribe the user case |
leonardBang
left a comment
There was a problem hiding this comment.
Thanks @gong for the update, LGTM . Will merge this PR once the CI green
|
The failed test is not related to current PR, merging. |
…se64 encoded string (apache#2435) This closes apache#2435.
dbzObj may be string when mysql cdc set with param 'debezium.binary.handling.mode' = 'base64'.
So add