Skip to content

[tests][e2e] add log properties file to e2e tests#2464

Merged
whhe merged 1 commit intoapache:masterfrom
loserwang1024:add-log-e2e
Sep 26, 2023
Merged

[tests][e2e] add log properties file to e2e tests#2464
whhe merged 1 commit intoapache:masterfrom
loserwang1024:add-log-e2e

Conversation

@loserwang1024
Copy link
Copy Markdown
Contributor

There is no log4j2-test.properties file in e2e tests, so it's hard to find problem in test.Now add log4j2-test.properties flie to e2e tests.

@loserwang1024
Copy link
Copy Markdown
Contributor Author

@yuxiqian , CC

@yuxiqian
Copy link
Copy Markdown
Member

yuxiqian commented Sep 7, 2023

LGTM

Irrelevant to this PR, but I noticed that log4j2-test.properties in flink-connector-db2-cdc sets it target as appender.testlogger.target = SYSTEM_OUT while all other tests use SYSTEM_ERR. Should this be fixed, too?

@loserwang1024
Copy link
Copy Markdown
Contributor Author

@yuxiqian , it seems that two output just with different color, not a big problem.

@yuxiqian
Copy link
Copy Markdown
Member

yuxiqian commented Sep 7, 2023

OK, no problems for me.

@whhe whhe merged commit 6ca87c4 into apache:master Sep 26, 2023
e-mhui pushed a commit to e-mhui/flink-cdc-connectors that referenced this pull request Oct 18, 2023
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants