fix: mongo collection regex match logic#2503
Merged
Jiabao-Sun merged 1 commit intoapache:masterfrom Sep 18, 2023
Merged
Conversation
Member
Author
Jiabao-Sun
approved these changes
Sep 18, 2023
Contributor
Jiabao-Sun
left a comment
Jiabao-Sun
left a comment
There was a problem hiding this comment.
Thanks @yuxiqian for this contribution.
LGTM.
e-mhui
pushed a commit
to e-mhui/flink-cdc-connectors
that referenced
this pull request
Oct 18, 2023
GOODBOY008
pushed a commit
to GOODBOY008/flink-cdc
that referenced
this pull request
Oct 30, 2023
(cherry picked from commit 35c112d)
GOODBOY008
pushed a commit
to GOODBOY008/flink-cdc
that referenced
this pull request
Oct 30, 2023
(cherry picked from commit 35c112d)
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 44cd46e introduces a change that using [.] as delimiter between database name and collection name to avoid conflicts between dot (
.) and regex meta character. However this turns out to be unnecessary since in Regex mode, full qualified names will always be used and no pasting will be performed then, and such change will deteriorate performance.This PR reverts the change above.