Skip to content

[hotfix][docs] Fix the abnormal display of pictures#2513

Merged
Jiabao-Sun merged 5 commits intoapache:masterfrom
gtk96:patch-1
Sep 22, 2023
Merged

[hotfix][docs] Fix the abnormal display of pictures#2513
Jiabao-Sun merged 5 commits intoapache:masterfrom
gtk96:patch-1

Conversation

@gtk96
Copy link
Copy Markdown
Contributor

@gtk96 gtk96 commented Sep 21, 2023

fix @lvyanquan the mentioned pictures show abnormality.

@gtk96
Copy link
Copy Markdown
Contributor Author

gtk96 commented Sep 21, 2023

@lvyanquan @Jiabao-Sun PTAL

@lvyanquan
Copy link
Copy Markdown
Contributor

lvyanquan commented Sep 21, 2023

It works.
What's more, you may need to add three spaces before your bash code and picture to avoid reordering sequence numbers.

截屏2023-09-21 上午11 31 25

Comment thread docs/content/about.md Outdated
@gtk96 gtk96 requested a review from lvyanquan September 22, 2023 01:03
@gtk96
Copy link
Copy Markdown
Contributor Author

gtk96 commented Sep 22, 2023

@Jiabao-Sun @GOODBOY008 PTAL

@lvyanquan
Copy link
Copy Markdown
Contributor

Sorry for bother you again OwO. after test, find that these lines in 3,4,5 in bash should also add spaces.

git clone https://github.com/your_name/flink-cdc-connectors.git
cd flink-cdc-connectors
mvn clean install -DskipTests

@gtk96 gtk96 requested a review from lvyanquan September 22, 2023 01:51
@lvyanquan
Copy link
Copy Markdown
Contributor

lvyanquan commented Sep 22, 2023

LGTM, Thanks for your patience.

Copy link
Copy Markdown
Contributor

@Jiabao-Sun Jiabao-Sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gtk96 for the great work.
LGTM

@Jiabao-Sun Jiabao-Sun merged commit c896df8 into apache:master Sep 22, 2023
@Jiabao-Sun
Copy link
Copy Markdown
Contributor

Thanks @lvyanquan for the helpful review.

@gtk96 gtk96 deleted the patch-1 branch September 22, 2023 02:50
e-mhui pushed a commit to e-mhui/flink-cdc-connectors that referenced this pull request Oct 18, 2023
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants