-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[WIP][mysql] Add ExternalSystemListener to notify user about the status of connector. #2523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi, @ruanhang1993 |
|
@lvyanquan I've been so busy at work and was just about to implement it, but you've already implemented it! 🤣🤣🤣 Can I run this pr with our company in-house notification tools and give you some comment??🙇🏻♂️🙇🏻♂️ |
I added some information (e.g. As our team implemented and used this notification feature, we realized that the I hope you give it a try, and thanks for any comments!! 😄🙇🏻♂️ |
|
It makes sense to me, and I create an abstract class AbstractListenerMessage since there are other datasources like oracle、postgreSQL. |
LGTM! |
| return properties; | ||
| } | ||
|
|
||
| Properties properties = new Properties(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This field 'properties' is for?
|
Is there any progress on this PR? cc @lvyanquan |
|
This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. |
|
This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. |
|
This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. |
|
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request. |
this closes #2520
Try to support notification about the status of connector, since it may be a common demand from community.
However, I met some problem when add a preliminary implementation, want to get some advice from yours.