Skip to content

Conversation

@lvyanquan
Copy link
Contributor

this closes #2520

Try to support notification about the status of connector, since it may be a common demand from community.
However, I met some problem when add a preliminary implementation, want to get some advice from yours.

  1. When I try to define an enum of ExternalSystemEvent, I found that it's similar to AssignerStatus, can we reuse it?
  2. Should we send information about finished splits to listener? then it would be very similar to checkpoint.
  3. Should we add a default implement like KafkaListener?

@lvyanquan
Copy link
Contributor Author

lvyanquan commented Sep 26, 2023

Hi, @ruanhang1993
Not sure if my design and confusion are reasonable, Looking forward to your advice. 😊

@SML0127
Copy link
Contributor

SML0127 commented Oct 1, 2023

@lvyanquan
Wow..
First of all, Thank you for implementing this function I was hoping for.

I've been so busy at work and was just about to implement it, but you've already implemented it! 🤣🤣🤣

Can I run this pr with our company in-house notification tools and give you some comment??🙇🏻‍♂️🙇🏻‍♂️

@SML0127
Copy link
Contributor

SML0127 commented Oct 1, 2023

@lvyanquan Wow.. First of all, Thank you for implementing this function I was hoping for.

I've been so busy at work and was just about to implement it, but you've already implemented it! 🤣🤣🤣

Can I run this pr with our company in-house notification tools and give you some comment??🙇🏻‍♂️🙇🏻‍♂️

I added some information (e.g. startupMode, gtids) for notification message and created PR.

As our team implemented and used this notification feature, we realized that the startupMode and gtids information was really useful. So I added it.

I hope you give it a try, and thanks for any comments!! 😄🙇🏻‍♂️

@lvyanquan
Copy link
Contributor Author

It makes sense to me, and I create an abstract class AbstractListenerMessage since there are other datasources like oracle、postgreSQL.

@SML0127
Copy link
Contributor

SML0127 commented Oct 2, 2023

It makes sense to me, and I create an abstract class AbstractListenerMessage since there are other datasources like oracle、postgreSQL.

LGTM!
I learn a lot from your implementation😃

return properties;
}

Properties properties = new Properties();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field 'properties' is for?

@yuxiqian
Copy link
Member

Is there any progress on this PR? cc @lvyanquan

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Jul 17, 2024
@github-actions github-actions bot removed the Stale label Jul 26, 2024
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs.

@github-actions github-actions bot added Stale and removed Stale labels Sep 24, 2024
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Nov 24, 2024
@github-actions
Copy link

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.

@github-actions github-actions bot closed this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add external listeners to obtain split information

4 participants