[3.0][cdc-runtime] add DataSinkWriterOperator to process Event#2649
Merged
ruanhang1993 merged 8 commits intoapache:masterfrom Nov 9, 2023
lvyanquan0624:WriterOperator
Merged
[3.0][cdc-runtime] add DataSinkWriterOperator to process Event#2649ruanhang1993 merged 8 commits intoapache:masterfrom lvyanquan0624:WriterOperator
ruanhang1993 merged 8 commits intoapache:masterfrom
lvyanquan0624:WriterOperator
Conversation
Contributor
|
@lvyanquan Thanks for the pull request!
|
ruanhang1993
reviewed
Nov 7, 2023
Contributor
Author
SupportSchemaEvolutionWriting is designed for SinkWriter, just to separate the processing logic of SchemaChangeEvent and
Keep this code currently until another implementation is available |
…or to remove hard-coding SCHEMA_EVOLUTION_OPERATOR_ID
PatrickRen
reviewed
Nov 8, 2023
Contributor
PatrickRen
left a comment
There was a problem hiding this comment.
@lvyanquan Thanks for the pull request! I left some comments.
PatrickRen
reviewed
Nov 8, 2023
Contributor
PatrickRen
left a comment
There was a problem hiding this comment.
Two tiny comments for the operator
PatrickRen
reviewed
Nov 8, 2023
Contributor
PatrickRen
left a comment
There was a problem hiding this comment.
@lvyanquan Sorry for flushing your thread! Found another issue.
PatrickRen
approved these changes
Nov 9, 2023
Contributor
PatrickRen
left a comment
There was a problem hiding this comment.
@lvyanquan Thanks for the update! LGTM.
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #2605
points to be discussed:
privatescope?@PatrickRen @ruanhang1993 cc and Looking forward to your suggestions.