Skip to content

[3.0][cdc-common] Add SchemaChangeEvent implementations#2664

Merged
ruanhang1993 merged 3 commits intoapache:masterfrom
lvyanquan0624:schemachangeevent
Nov 9, 2023
Merged

[3.0][cdc-common] Add SchemaChangeEvent implementations#2664
ruanhang1993 merged 3 commits intoapache:masterfrom
lvyanquan0624:schemachangeevent

Conversation

@lvyanquan
Copy link
Copy Markdown
Contributor

Comment thread flink-cdc-common/src/main/java/com/ververica/cdc/common/event/AddColumnEvent.java Outdated
@Jiabao-Sun
Copy link
Copy Markdown
Contributor

Do we need to support RenameTableEvent and DropTableEvent?

@lvyanquan
Copy link
Copy Markdown
Contributor Author

Do we need to support RenameTableEvent and DropTableEvent?

TableId of sink is created at Route stage, We can't create RenameTableEvent and DropTableEvent until User goes to modify the configuration.

@ruanhang1993
Copy link
Copy Markdown
Contributor

ruanhang1993 commented Nov 9, 2023

@lvyanquan Because SchemaChangeEvent will be put in CoordinationRequest which is Serializable, we should make SchemaChangeEvent implement Serializable.

@lvyanquan
Copy link
Copy Markdown
Contributor Author

Some commits were add by mistakes, will resubmit it later.

@lvyanquan
Copy link
Copy Markdown
Contributor Author

@ruanhang1993 CC again.

Comment thread flink-cdc-common/src/main/java/com/ververica/cdc/common/event/AddColumnEvent.java Outdated
Comment thread flink-cdc-common/src/main/java/com/ververica/cdc/common/event/AddColumnEvent.java Outdated
Comment thread flink-cdc-common/src/main/java/com/ververica/cdc/common/event/AddColumnEvent.java Outdated
Comment thread flink-cdc-common/src/main/java/com/ververica/cdc/common/event/AddColumnEvent.java Outdated
Copy link
Copy Markdown
Contributor

@ruanhang1993 ruanhang1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanhang1993 ruanhang1993 merged commit c52ccfa into apache:master Nov 9, 2023
@lvyanquan lvyanquan mentioned this pull request Dec 18, 2023
2 tasks
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[flink-cdc-common] Add SchemaChangeEvent implementation

3 participants