[3.0][cdc-common] Add ConText for Source/Sink initialization.#2672
Merged
GOODBOY008 merged 1 commit intoapache:masterfrom Nov 17, 2023
Merged
[3.0][cdc-common] Add ConText for Source/Sink initialization.#2672GOODBOY008 merged 1 commit intoapache:masterfrom
GOODBOY008 merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
@lvyanquan @GOODBOY008 @PatrickRen PTAL. |
Contributor
|
Pass Context to DataSinkFactory/DataSourceFactory, like DynamicTableSourceFactory. |
lvyanquan
reviewed
Nov 9, 2023
|
|
||
| /** A helper for working with {@link Factory}. */ | ||
| @PublicEvolving | ||
| public class FactoryHelper { |
Contributor
There was a problem hiding this comment.
Not sure this class is necessary, @GOODBOY008 What do you think?
Contributor
|
getConfiguration method is also necessary to get ConfigOption, so you may need to wait #2668 to be done. |
joyCurry30
force-pushed
the
2666_add_context
branch
from
13003ce to
e5160cf
Compare
joyCurry30
force-pushed
the
2666_add_context
branch
2 times, most recently
from
d4803d3 to
547ad88
Compare
lvyanquan
reviewed
Nov 17, 2023
whhe
reviewed
Nov 17, 2023
joyCurry30
force-pushed
the
2666_add_context
branch
from
547ad88 to
05c7a40
Compare
e-mhui
pushed a commit
to e-mhui/flink-cdc-connectors
that referenced
this pull request
Dec 2, 2023
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to #2666
We should add 'ConText' with options for Source/Sink initialization.