[3.0][cdc-common] Change DataChangeEvent from interface to class, and add implementation for DataChangeEvent.#2677
Merged
GOODBOY008 merged 3 commits intoapache:masterfrom Nov 9, 2023
Conversation
joyCurry30
force-pushed
the
2665_add_implementation_datachange_event
branch
from
d06a4ab to
e449112
Compare
… add implementation for DataChangeEvent.
joyCurry30
force-pushed
the
2665_add_implementation_datachange_event
branch
from
e449112 to
f943ec8
Compare
GOODBOY008
approved these changes
Nov 9, 2023
Member
GOODBOY008
left a comment
GOODBOY008
left a comment
There was a problem hiding this comment.
Thanks for you contritbutions, I left a minor comment.
GOODBOY008
reviewed
Nov 9, 2023
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
… add implementation for DataChangeEvent. (apache#2677) * [3.0][cdc-common] Change DataChangeEvent from interface to class, and add implementation for DataChangeEvent. * [3.0][cdc-common] Remove @param for code cleaning. * [3.0][cdc-common] Make the DataChangeEvent constructor private.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to #2665
Change DataChangeEvent from interface to class, and add implementation for DataChangeEvent.
PTAL. @lvyanquan @GOODBOY008