[common] Introduce Configuration and related utilities#2681
Merged
PatrickRen merged 5 commits intoapache:masterfrom Nov 16, 2023
Merged
[common] Introduce Configuration and related utilities#2681PatrickRen merged 5 commits intoapache:masterfrom
PatrickRen merged 5 commits intoapache:masterfrom
Conversation
GOODBOY008
reviewed
Nov 10, 2023
PatrickRen
force-pushed
the
introduce-configuration
branch
2 times, most recently
from
dbe8485 to
d08f304
Compare
Contributor
|
@PatrickRen could you rebase your PR to latest master ? |
PatrickRen
force-pushed
the
introduce-configuration
branch
2 times, most recently
from
91628cb to
ff54a15
Compare
leonardBang
approved these changes
Nov 15, 2023
Contributor
leonardBang
left a comment
leonardBang
left a comment
There was a problem hiding this comment.
Thanks @PatrickRen for the update, LGTM, I only left one comment, feel free to merge it once resolved it.
PatrickRen
force-pushed
the
introduce-configuration
branch
from
ff54a15 to
17286d8
Compare
2 tasks
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces
Configurationand its related utilities such asConfigOption, and migrate current usage of FlinkConfigurationto CDC's own one inflink-cdc-composerandflink-cdc-cli.Please note that most code blocks are borrowed from Flink, and some deprecated and redundant methods are dropped.