[3.0][cdc-common] Add TypeSerializer implementations#2683
[3.0][cdc-common] Add TypeSerializer implementations#2683ruanhang1993 merged 6 commits intoapache:masterfrom
Conversation
|
Over all, LGTM. |
| import java.util.Arrays; | ||
|
|
||
| /** TODO: A {@link TypeSerializer} for {@link ChangeEvent}. */ | ||
| public final class ChangeEventSerializer extends TypeSerializer<ChangeEvent> { |
There was a problem hiding this comment.
We also need a EventSerializer, as Event is the intermediate class from Source to Sink.
There was a problem hiding this comment.
If we need this, I think it is better to create a new issue to trace it.
|
@ruanhang1993 Thanks for the contribution, would you wind help review and merge my type pr[1] firstly? And then, we can finish all serializer work in this PR. [1]#2688 |
leonardBang
left a comment
leonardBang
left a comment
There was a problem hiding this comment.
Thanks @ruanhang1993 for the contribution, I left some comments
|
Thanks @ruanhang1993 for the update, could you fix the compile issue and add some tests, I think we can open some follow-up sub tasks to add more tests |
Thanks. Fixed it. I will add tests in #2713. |
leonardBang
left a comment
leonardBang
left a comment
There was a problem hiding this comment.
Thanks @ruanhang1993 for the update, LGTM, let's push the core runtime implementation first
[3.0][cdc-runtime] Add OperatorEvent and CoordinationRequest implementations [3.0][cdc-runtime] Add SchemaOperatorCoordinator to apply schema change [3.0][cdc-runtime] Add SchemaOperator to notify schema change and block data fix fix review fix review fix Revert "[3.0][cdc-common] Add TypeSerializer implementations (apache#2683)" This reverts commit af5a0ce.
4 participants
Add TypeSerializer implementations