Skip to content

[oracle-cdc] fix oracle cdc data lose during the snapshot to incremental process#2707

Closed
yunqingmoswu wants to merge 2 commits intoapache:masterfrom
yunqingmoswu:feature-oracle-cdc-2706
Closed

[oracle-cdc] fix oracle cdc data lose during the snapshot to incremental process#2707
yunqingmoswu wants to merge 2 commits intoapache:masterfrom
yunqingmoswu:feature-oracle-cdc-2706

Conversation

@yunqingmoswu
Copy link
Copy Markdown

fix oracle cdc data lose during the snapshot to incremental process.

@EMsnap
Copy link
Copy Markdown
Member

EMsnap commented Nov 16, 2023

image
please fix format check

@EMsnap
Copy link
Copy Markdown
Member

EMsnap commented Nov 16, 2023

could you please provide a detailed description on this issue ?

@yunqingmoswu
Copy link
Copy Markdown
Author

image please fix format check

done

@leonardBang
Copy link
Copy Markdown
Contributor

Thanks @yunqingmoswu for the contribution, the change looks good to me, could you add a test for this case?

@loserwang1024
Copy link
Copy Markdown
Contributor

loserwang1024 commented Nov 30, 2023

Thanks @yunqingmoswu for the contribution, the change looks good to me, could you add a test for this case?

@leonardBang @yunqingmoswu ,
It's not easy to add test now.
In #2553, I add hooks to do database operations during snapshot split code and also add test in it. However, that PR depends on this PR.Therefore, please merge this PR at first.

Detail see: #2772,
com.ververica.cdc.connectors.oracle.source.OracleSourceITCase#testEnableBackfillWithDMLPreHighWaterMark & testEnableBackfillWithDMLPostLowWaterMark

loserwang1024 pushed a commit to loserwang1024/flink-cdc-connectors that referenced this pull request Dec 1, 2023
e-mhui pushed a commit to e-mhui/flink-cdc-connectors that referenced this pull request Dec 2, 2023
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants