[oracle][doc] Fix oracle quick start#2727
Merged
leonardBang merged 2 commits intoapache:masterfrom Nov 24, 2023
Merged
Conversation
Member
Author
|
@YesOrNo828 PTAL |
752a119 to
003e88f
Compare
YesOrNo828
reviewed
Nov 22, 2023
Contributor
YesOrNo828
left a comment
There was a problem hiding this comment.
@GOODBOY008 I tested local env, but met this exception:
java.lang.IllegalArgumentException: Unable to convert to TimestampData from unexpected value '1596103702001' of type java.lang.Long
at com.ververica.cdc.connectors.oracle.table.OracleDeserializationConverterFactory$2.convert(OracleDeserializationConverterFactory.java:96)
at com.ververica.cdc.connectors.oracle.table.OracleDeserializationConverterFactory$3.convert(OracleDeserializationConverterFactory.java:117)
at com.ververica.cdc.debezium.table.RowDataDebeziumDeserializeSchema$17.convert(RowDataDebeziumDeserializeSchema.java:653)
I think we should change the Flink SQL DDL of table: orders.ORDER_DATE and enriched_orders.ORDER_DATE type to TIMESTAMP(3). And the quickstart would run successfully.
Member
Author
|
@YesOrNo828 Thank you for your careful check, I had modify code which you said. |
Member
Author
|
@leonardBang PTAL , Maybe back support to 2.4.x. |
leonardBang
reviewed
Nov 24, 2023
Contributor
leonardBang
left a comment
There was a problem hiding this comment.
Thanks @GOODBOY008 for the contribution and @YesOrNo828 for the review, LGTM.
feel free to merge and backport to release-2.4 branch.
leonardBang
approved these changes
Nov 24, 2023
GOODBOY008
added a commit
to GOODBOY008/flink-cdc
that referenced
this pull request
Nov 25, 2023
This closes apache#2727. (cherry picked from commit 9aed54d)
GOODBOY008
added a commit
that referenced
this pull request
Nov 25, 2023
e-mhui
pushed a commit
to e-mhui/flink-cdc-connectors
that referenced
this pull request
Dec 2, 2023
zhongqishang
pushed a commit
to zhongqishang/flink-cdc
that referenced
this pull request
Dec 7, 2023
This closes apache#2727. (cherry picked from commit 9aed54d)
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.