Skip to content

[3.0][cdc-common] Add binary record data#2734

Closed
ruanhang1993 wants to merge 6 commits intoapache:masterfrom
ruanhang1993:tests
Closed

[3.0][cdc-common] Add binary record data#2734
ruanhang1993 wants to merge 6 commits intoapache:masterfrom
ruanhang1993:tests

Conversation

@ruanhang1993
Copy link
Copy Markdown
Contributor

@ruanhang1993 ruanhang1993 commented Nov 23, 2023

Add binary record data and remove the rowType from DataChangeEvent. Fix #2748.

@ruanhang1993 ruanhang1993 force-pushed the tests branch 2 times, most recently from 7e1a0f8 to 164f7ff Compare November 24, 2023 04:23
@leonardBang leonardBang self-requested a review November 24, 2023 06:06
@leonardBang
Copy link
Copy Markdown
Contributor

@ruanhang1993 Thanks for your contribution, could your create a subtask for 3.0 and add some description for this PR?

Copy link
Copy Markdown
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ruanhang1993 for the great work, I left some comments

Comment thread flink-cdc-common/src/main/java/com/ververica/cdc/common/data/TimestampData.java Outdated
Copy link
Copy Markdown
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ruanhang1993 for the update, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cdc-common] Provide binary record data and remove rowType from DataChangeEvent

2 participants