[cdc-pipeline-connector] add MULTI_SPLITS_SINGLE_TABLE to provide multiple splits case of ValuesDataSourceHelper.#2737
Merged
leonardBang merged 2 commits intoapache:masterfrom Nov 27, 2023
lvyanquan0624:SourceEventHelper
Merged
[cdc-pipeline-connector] add MULTI_SPLITS_SINGLE_TABLE to provide multiple splits case of ValuesDataSourceHelper.#2737leonardBang merged 2 commits intoapache:masterfrom lvyanquan0624:SourceEventHelper
leonardBang merged 2 commits intoapache:masterfrom
lvyanquan0624:SourceEventHelper
Conversation
leonardBang
reviewed
Nov 24, 2023
Contributor
leonardBang
left a comment
leonardBang
left a comment
There was a problem hiding this comment.
Thanks @lvyanquan for the contribution, could you add some basic test for new introduced cases
Contributor
Author
A test for MULTI_SPLITS_SINGLE_TABLE was added and modify ValuesDataSource to support switching from snapshot stage to incremental stage. |
leonardBang
reviewed
Nov 25, 2023
Contributor
leonardBang
left a comment
leonardBang
left a comment
There was a problem hiding this comment.
Thanks @lvyanquan for the contribution, I left some comments
Contributor
Author
|
Address it. |
leonardBang
reviewed
Nov 26, 2023
Contributor
|
@lvyanquan A rebase action is welcome |
…uesDataSourceHelper.
…vide multiple splits case of ValuesDataSourceHelper.
Contributor
Author
done. |
leonardBang
approved these changes
Nov 27, 2023
Contributor
leonardBang
left a comment
leonardBang
left a comment
There was a problem hiding this comment.
Thanks @lvyanquan for the update, LGTM
e-mhui
pushed a commit
to e-mhui/flink-cdc-connectors
that referenced
this pull request
Dec 2, 2023
…BLE to mock source with multiple splits (apache#2737) This closes apache#2737.
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
…BLE to mock source with multiple splits (apache#2737) This closes apache#2737.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add MULTI_SPLITS_SINGLE_TABLE to provide multiple splits case of ValuesDataSourceHelper.