[cdc-composer] fix CI and initial Context with existed config from SourceDef and SinkDef.#2749
Merged
leonardBang merged 2 commits intoapache:masterfrom Nov 24, 2023
lvyanquan0624:ci_composer
Merged
[cdc-composer] fix CI and initial Context with existed config from SourceDef and SinkDef.#2749leonardBang merged 2 commits intoapache:masterfrom lvyanquan0624:ci_composer
leonardBang merged 2 commits intoapache:masterfrom
lvyanquan0624:ci_composer
Conversation
…urceDef and SinkDef.
lvyanquan
changed the title
leonardBang
reviewed
Nov 24, 2023
Contributor
leonardBang
left a comment
leonardBang
left a comment
There was a problem hiding this comment.
Thanks @lvyanquan for the contribution, a test is welcome
…urceDef and SinkDef.
Contributor
Author
Address it. |
leonardBang
approved these changes
Nov 24, 2023
Contributor
leonardBang
left a comment
leonardBang
left a comment
There was a problem hiding this comment.
Thanks @lvyanquan for the update, LGTM, wait the ci green
e-mhui
pushed a commit
to e-mhui/flink-cdc-connectors
that referenced
this pull request
Dec 2, 2023
…nd SinkDef (apache#2749) This closes apache#2749.
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
…nd SinkDef (apache#2749) This closes apache#2749.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configuration provide a convenient way for DataSourceFactory to get ConfigOption.
@PatrickRen @leonardBang CC.