Skip to content

[cdc-pipeline-connector][values] Avoid using default as name of namespace and schema.#2774

Merged
PatrickRen merged 1 commit intoapache:masterfrom
lvyanquan0624:values
Nov 29, 2023
Merged

[cdc-pipeline-connector][values] Avoid using default as name of namespace and schema.#2774
PatrickRen merged 1 commit intoapache:masterfrom
lvyanquan0624:values

Conversation

@lvyanquan
Copy link
Copy Markdown
Contributor

@lvyanquan lvyanquan commented Nov 28, 2023

Because default may be keyword for some connectors, and could not be a name of database like doris.

@lvyanquan
Copy link
Copy Markdown
Contributor Author

@leonardBang PTAL.

Copy link
Copy Markdown
Contributor

@PatrickRen PatrickRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lvyanquan Thanks for the PR! LGTM.

@PatrickRen PatrickRen merged commit 8edf2a6 into apache:master Nov 29, 2023
@leonardBang leonardBang added this to the V3.0.0 milestone Nov 29, 2023
e-mhui pushed a commit to e-mhui/flink-cdc-connectors that referenced this pull request Dec 2, 2023
ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants