[cdc-composer] Add integration test for FlinkPipelineComposer#2776
Merged
leonardBang merged 3 commits intoapache:masterfrom Dec 2, 2023
Merged
[cdc-composer] Add integration test for FlinkPipelineComposer#2776leonardBang merged 3 commits intoapache:masterfrom
leonardBang merged 3 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@lvyanquan Could you take a look at this one? Thanks! |
Contributor
|
@PatrickRen Could you check the CI failure? |
lvyanquan
reviewed
Dec 1, 2023
| new MiniClusterExtension( | ||
| new MiniClusterResourceConfiguration.Builder() | ||
| .setNumberTaskManagers(1) | ||
| .setNumberSlotsPerTaskManager(MAX_PARALLELISM) |
Contributor
There was a problem hiding this comment.
we need to make ValuesDatabase class load by AppClassloader to avoid unexpected results.
static final org.apache.flink.configuration.Configuration configuration = new org.apache.flink.configuration.Configuration();
static {
configuration.set(ALWAYS_PARENT_FIRST_LOADER_PATTERNS_ADDITIONAL, Collections.singletonList("com.ververica.cdc"));
}
Contributor
There was a problem hiding this comment.
Could you change this part and add some tests @PatrickRen
Contributor
Author
There was a problem hiding this comment.
@lvyanquan Thanks for the solution! I think as a temporary solution this is OK. Maybe we can make some improvements for the ValuesDatabase in the future, like let it lays in an operator coordinator, and we can get talk to it via ClusterClient#sendCoordinationRequest
PatrickRen
force-pushed
the
add-composer-it-case
branch
from
ba1192c to
31761f8
Compare
PatrickRen
force-pushed
the
add-composer-it-case
branch
from
31761f8 to
86d3065
Compare
leonardBang
approved these changes
Dec 2, 2023
Contributor
leonardBang
left a comment
leonardBang
left a comment
There was a problem hiding this comment.
Thanks @PatrickRen and @lvyanquan for the contribution, CI passed, merging
e-mhui
pushed a commit
to e-mhui/flink-cdc-connectors
that referenced
this pull request
Dec 2, 2023
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds integration test for
FlinkPipelineComposer