Skip to content

[cdc-connector][sqlserver][tests] Fix UT errors by increasing the wait time after committing SQL#2799

Merged
leonardBang merged 1 commit intoapache:masterfrom
gong:fix-ut-error
Dec 2, 2023
Merged

[cdc-connector][sqlserver][tests] Fix UT errors by increasing the wait time after committing SQL#2799
leonardBang merged 1 commit intoapache:masterfrom
gong:fix-ut-error

Conversation

@gong
Copy link
Copy Markdown
Contributor

@gong gong commented Dec 2, 2023

Fix UT errors by increasing the wait time after committing SQL.
commit() can't be not effective when wait 1s. So change 1s to 5s.
image

@gong
Copy link
Copy Markdown
Contributor Author

gong commented Dec 2, 2023

@leonardBang PTAL

Copy link
Copy Markdown
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gong for the troubleshooting, let's keep an eye on the CI result

@gong gong requested a review from leonardBang December 2, 2023 14:27
@leonardBang leonardBang merged commit 2d9dc01 into apache:master Dec 2, 2023
@loserwang1024
Copy link
Copy Markdown
Contributor

@gong , @leonardBang , @GOODBOY008 , at first, it occurs sporadically so I set the time to 1s, and then problem does not occur.
However, it happens again later, so change 1s to 5s in this pr. It seem ok again.

But, in today's CI: https://github.com/ververica/flink-cdc-connectors/pull/2839/checks?check_run_id=19439442657 today, same problem occurs again.

Maybe we should find the real reason, not only increase the time. For example, maybe the data is not cleaned up in a timely manner, the container disk becomes full and unable to flush data.

ChaomingZhangCN pushed a commit to ChaomingZhangCN/flink-cdc that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants