[mysql-cdc] Current binlog offset add serverId, fix incremental-snapshot scan data lose #2808
Conversation
…hot scan data lose
ruanhang1993
left a comment
ruanhang1993
left a comment
There was a problem hiding this comment.
@EchoLee5 Thanks for the fix. Could you add some tests to cover this bug?
I think we could start a mysql container without gtid-mode = on to reproduce this bug.
|
The problem will occur when the gtid mode is closed and some data changes happen in the snapshot phase. |
Sorry for being late, I have added unit tests, please review them for me, thank you! |
|
Hi @EchoLee5, could you please rebase this PR with latest |
|
This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. |
|
This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. |
|
This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs. |
|
This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request. |
3 participants
Current binlog offset add serverId, fix incremental-snapshot scan data lose
link #2794