Skip to content

[cdc-common] Add default value of pipeline parallelism.#2831

Closed
joyCurry30 wants to merge 1 commit intoapache:masterfrom
joyCurry30:add_default_value_of_parallelism
Closed

[cdc-common] Add default value of pipeline parallelism.#2831
joyCurry30 wants to merge 1 commit intoapache:masterfrom
joyCurry30:add_default_value_of_parallelism

Conversation

@joyCurry30
Copy link
Contributor

@joyCurry30 joyCurry30 commented Dec 7, 2023

Refer to #2855
Add default value of pipeline parallelism. cc @lvyanquan

@github-actions github-actions bot added the common label Dec 7, 2023
Copy link
Contributor

@lvyanquan lvyanquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ConfigOptions.key("parallelism")
.intType()
.noDefaultValue()
.defaultValue(1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a public API change, we only introduce this in 3.1 version, we need some discussion in dev group

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leonardBang Thank you for review. I have supplemented the relevant issues accordingly #2855 .

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Jul 17, 2024
@github-actions github-actions bot removed the Stale label Jul 26, 2024
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs.

@github-actions github-actions bot added Stale and removed Stale labels Sep 24, 2024
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity for 60 days. It will be closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Nov 24, 2024
@github-actions
Copy link

This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.

@github-actions github-actions bot closed this Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants