[minor] Fix SQL injection vulnerabilities in OceanBase connector #4124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix executeSingleColumnStatement method in OceanBaseCatalog.java to support parameterized queries - Fix databaseExists and tableExists methods in OceanBaseMySQLCatalog.java to use parameterized queries instead of string concatenation - Update method signature in OceanBaseTestMySQLCatalog.java to match parent class - Add SQL injection prevention test cases to verify parameterized queries effectively prevent SQL injection attacks - Adjust exception logging levels: SQL syntax errors use WARN level, other errors use ERROR level This addresses the SQL injection security issues reported by the Apache team by using PreparedStatement parameterized queries to prevent malicious SQL injection attacks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes SQL injection vulnerabilities in OceanBase connector's
databaseExistsandtableExistsmethods by replacing string concatenation with parameterized queries.Changes
executeSingleColumnStatementdatabaseExistsandtableExiststo usePreparedStatementSecurity Analysis
databaseExistsandtableExistsmethods now use parameterized queriescreateTablemethod uses proper identifier quoting with backticks, no changes neededSecurity Fix
Before:
String.format("SELECT ... WHERE SCHEMA_NAME = '%s'", databaseName)❌After:
PreparedStatementwith parameterized queries ✅