[FLINK-39168][cdc-connector-mysql] Cache splitId local variable to avoid redundant method calls in getFinishedSplitInfos #4288
Merged
lvyanquan merged 1 commit intoapache:masterfrom Feb 27, 2026
Conversation
… method twice per iteration: - Clarity: Makes it explicit that both usages refer to the same value, improving readability. - Consistency: Eliminates any theoretical risk if splitId() were ever changed to a non-pure method in the future. - Minor efficiency: Avoids a redundant method dispatch on every iteration of the loop.
ThorneANN
changed the title
Contributor
Author
|
@Copilot review |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves readability and avoids redundant method calls in the MySQL CDC snapshot split assigner by caching split.splitId() in a local variable when building finished split metadata.
Changes:
- Cache
split.splitId()into a localsplitIdvariable insidegetFinishedSplitInfos(). - Use the cached
splitIdfor both map lookup (splitFinishedOffsets.get(...)) andFinishedSnapshotSplitInfoconstruction.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache split.splitId() result in a local variable to avoid calling the method twice per iteration: