[FLINK-39346] Improve the error message when the AddColumnEvent fails#4353
Merged
Conversation
Signed-off-by: Pei Yu <125331682@qq.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Improves diagnostics around SchemaUtils.applyAddColumnEvent failures by enriching IllegalArgumentException messages with event/table context, making it easier to debug AddColumnEvent insertion errors.
Changes:
- Expand
IllegalArgumentExceptionmessages forAddColumnEventBEFORE/AFTERinsertion failures to include table id and referenced column name. - Add unit tests asserting the improved error messages for invalid
BEFORE/AFTERreferences.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| flink-cdc-common/src/main/java/org/apache/flink/cdc/common/utils/SchemaUtils.java | Improves error messages thrown when AddColumnEvent references a non-existent column in BEFORE/AFTER positions. |
| flink-cdc-common/src/test/java/org/apache/flink/cdc/common/utils/SchemaUtilsTest.java | Adds assertions to validate the improved AddColumnEvent failure messages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Pei Yu <125331682@qq.com>
ThorneANN
pushed a commit
to ThorneANN/flink-cdc
that referenced
this pull request
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding error event information to the error message can help resolve the problem more quickly.