[FLINK-39777] Support configurable HashFunction strategies in PrePartitionOperator#4423
Open
haruki-830 wants to merge 2 commits into
Open
[FLINK-39777] Support configurable HashFunction strategies in PrePartitionOperator#4423haruki-830 wants to merge 2 commits into
haruki-830 wants to merge 2 commits into
Conversation
Contributor
Author
|
@lvyanquan could you please help review this PR? |
lvyanquan
reviewed
Jun 3, 2026
Contributor
There was a problem hiding this comment.
Thanks @haruki-830 for the feature, left some comments.
| "The timeout time for SchemaOperator to wait downstream SchemaChangeEvent applying finished, the default value is 3 minutes."); | ||
|
|
||
| public static final ConfigOption<HashFunctionStrategy> PIPELINE_PARTITIONING_STRATEGY = | ||
| ConfigOptions.key("partitioning.strategy") |
Contributor
There was a problem hiding this comment.
Please update the document to guide users on how to use it.
Contributor
lvyanquan
reviewed
Jun 3, 2026
| Optional.ofNullable(tableId.getNamespace()).ifPresent(objectsToHash::add); | ||
| Optional.ofNullable(tableId.getSchemaName()).ifPresent(objectsToHash::add); | ||
| objectsToHash.add(tableId.getTableName()); | ||
| this.cachedHash = (Objects.hash(objectsToHash.toArray()) * 31) & 0x7FFFFFFF; |
Contributor
There was a problem hiding this comment.
Using TableId#hashCode directly instead of Objects.hash(objectsToHash.toArray()) would be simpler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds configurable partitioning strategy support to Flink CDC pipelines, enabling users to switch to table-id hashing for small tables via YAML configuration, reducing unnecessary primary-key hashing overhead.
Key Changes
Configuration Example
Route same-table events to a single subtask
Force load-balanced distribution by primary keys
JIRA Reference
https://issues.apache.org/jira/browse/FLINK-39777