[FLINK-31566][docker] Removes 1.15 and adds 1.17 Dockerfiles #153
Conversation
|
I needed to do a force-push because I wanted to update the commit message for the commit that added the 1.17.0 Dockerimages to comply with the README. |
|
And another force push was necessary because I realized that we had the GHA workflows not covered. |
| branch: dev-1.17 | ||
| - flink_version: 1.16-SNAPSHOT | ||
| branch: dev-1.16 | ||
| - flink_version: 1.15-SNAPSHOT |
There was a problem hiding this comment.
tbh. here I'm not 100% sure considering the discussion we had about having a final patch version release.
There was a problem hiding this comment.
According to the discussion we still need to release 1.15.5 as the final flushing version. Then I think 1.15 related contents should be kept until the final 1.15.5 is released. Otherwise we will never be able to release the 1.15.5 to the docker-library/official-images repo, as a new release requires to point to a commit on master.
IIUC the workflow handling an end-of-support version (let say 1.15 here) would be:
- We keep 1.15 related contents on master
- Once the final version 1.15.5 is ready, release the Docker image following the guide in README.md
- Remove 1.15 related contents from master after 1.15.5 is successfully published to Docker official
- Remove 1.15 related contents from library/flink in official-images repo
WDYT?
There was a problem hiding this comment.
Initially, I had the concern that we would miss deleting it if the community decide that they don't want another patch release for the deprecated minor version (for the current release I mean 1.15.5). But you're right - in the worst case we delete it later on.
PatrickRen
left a comment
PatrickRen
left a comment
There was a problem hiding this comment.
Thanks for the PR, and detailed updates on the README @XComp ! This truly helps release managers in future releases.
I do have some concerns considering the discussion about final patch version you mentioned. I replied in your comments.
| branch: dev-1.17 | ||
| - flink_version: 1.16-SNAPSHOT | ||
| branch: dev-1.16 | ||
| - flink_version: 1.15-SNAPSHOT |
There was a problem hiding this comment.
According to the discussion we still need to release 1.15.5 as the final flushing version. Then I think 1.15 related contents should be kept until the final 1.15.5 is released. Otherwise we will never be able to release the 1.15.5 to the docker-library/official-images repo, as a new release requires to point to a commit on master.
IIUC the workflow handling an end-of-support version (let say 1.15 here) would be:
- We keep 1.15 related contents on master
- Once the final version 1.15.5 is ready, release the Docker image following the guide in README.md
- Remove 1.15 related contents from master after 1.15.5 is successfully published to Docker official
- Remove 1.15 related contents from library/flink in official-images repo
WDYT?
rmetzger
left a comment
rmetzger
left a comment
There was a problem hiding this comment.
Changes look good. Thanks for updating the docs.
… all supported versions point to the right dev-* branches 1.15 is left in there for now because we might want to release 1.15.5
- Adds item check for `.github/workflows/snapshot.yml` - Adds item updating the .github/workflows/snapshot.yml - Updated the instructions on how to create a branch (following what's already documented in the Flink release docs). - Removed step in checklist to update the aliases array in generate-stackbrew-library.sh: This became obsolete with the changes that happened in e47a802 - Moved step describing the Flink minor version branch creation and updated it slightly to match the release documentation - Removed step for updating the base version in testing/run_travis_tests.sh: This is obsolete with the changes that were done in FLINK-27488 - Removed step asking to update the latest tag in the script: This is not necessary anymore after the changes that have been committed with e47a802.
|
Thanks for the review, @PatrickRen and @rmetzger . I squashed the changes into meaningful chunks (and left 1.15 data in for now). @rmetzger will pick up the work on FLINK-31566 after the changes are merged. |
3 participants
This also includes some minor documentation fixes where I removed steps that are not necessary anymore (see the commit message for the reasoning)