Update Dockerfiles for 1.19.0 release #186
Conversation
MartijnVisser
left a comment
MartijnVisser
left a comment
There was a problem hiding this comment.
I think it's good, left one comment to double check
| chown -R flink:flink .; \ | ||
| \ | ||
| # Replace default REST/RPC endpoint bind address to use the container's network interface \ | ||
| CONF_FILE="$FLINK_HOME/conf/flink-conf.yaml"; \ |
There was a problem hiding this comment.
Is this still correct, given the new YAML parser?
There was a problem hiding this comment.
Good reminder! Seems there's a fallback logic here. I'll check the code and also dist package to verify it.
There was a problem hiding this comment.
I checked both the FLINK-33297 and FLIP-366, the default configuration file has been changed to config.yaml, but the script is compatible with the old flink-conf.yaml file.
This is FLIP-366's expected behavior (For compatibility reasons, in Flink 1.x, if the old configuration file flink-conf.yaml exists in the Flink conf directory, Flink will ignore the new configuration file and use the old parser to parse flink-conf.yaml as the Flink configuration. In Flink 2.x, Flink will no longer support parsing the old configuration file flink-conf.yaml).
lincoln-lil
left a comment
lincoln-lil
left a comment
There was a problem hiding this comment.
Thanks @MartijnVisser for reviewing this!
| chown -R flink:flink .; \ | ||
| \ | ||
| # Replace default REST/RPC endpoint bind address to use the container's network interface \ | ||
| CONF_FILE="$FLINK_HOME/conf/flink-conf.yaml"; \ |
There was a problem hiding this comment.
I checked both the FLINK-33297 and FLIP-366, the default configuration file has been changed to config.yaml, but the script is compatible with the old flink-conf.yaml file.
This is FLIP-366's expected behavior (For compatibility reasons, in Flink 1.x, if the old configuration file flink-conf.yaml exists in the Flink conf directory, Flink will ignore the new configuration file and use the old parser to parse flink-conf.yaml as the Flink configuration. In Flink 2.x, Flink will no longer support parsing the old configuration file flink-conf.yaml).
2 participants
Uh oh!
There was an error while loading. Please reload this page.