Skip to content

Conversation

@yunfengzhou-hub
Copy link
Contributor

No description provided.

@yunfengzhou-hub yunfengzhou-hub force-pushed the FLINK-27294-python branch 3 times, most recently from 4d30bb2 to 6875de7 Compare May 20, 2022 08:42
Copy link
Contributor

@HuangXingBo HuangXingBo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yunfengzhou-hub Thanks a lot for the PR. I only have left one comment and will resolve it before merge.

*.pyc
flink-ml-python/dist/
flink-ml-python/apache_flink_ml.egg-info/
flink-ml-python/venv/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, we don't need to add this. Putting venv in the source directory is not a standard way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants