[FLINK-29011] Add Transformer for Binarizer #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yunfengzhou-hub
left a comment
yunfengzhou-hub
left a comment
There was a problem hiding this comment.
Thanks for the PR. Left some comments as below.
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/binarizer/BinarizerParams.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/binarizer/Binarizer.java
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/feature/BinarizerTest.java
Outdated
Show resolved
Hide resolved
flink-ml-lib/src/test/java/org/apache/flink/ml/feature/BinarizerTest.java
Outdated
Show resolved
Hide resolved
flink-ml-examples/src/main/java/org/apache/flink/ml/examples/feature/BinarizerExample.java
Outdated
Show resolved
Hide resolved
flink-ml-examples/src/main/java/org/apache/flink/ml/examples/feature/BinarizerExample.java
Outdated
Show resolved
Hide resolved
flink-ml-examples/src/main/java/org/apache/flink/ml/examples/feature/BinarizerExample.java
Show resolved
Hide resolved
Contributor
yunfengzhou-hub
left a comment
yunfengzhou-hub
left a comment
There was a problem hiding this comment.
Thanks for the update. Left some comments as below.
flink-ml-lib/src/test/java/org/apache/flink/ml/feature/BinarizerTest.java
Outdated
Show resolved
Hide resolved
weibozhao
force-pushed
the
FLINK-29011
branch
2 times, most recently
from
41cd102 to
29d17c7
Compare
Contributor
yunfengzhou-hub
left a comment
yunfengzhou-hub
left a comment
There was a problem hiding this comment.
Thanks for the update. It LGTM.
zhipeng93
reviewed
Aug 30, 2022
Contributor
zhipeng93
left a comment
zhipeng93
left a comment
There was a problem hiding this comment.
Thanks for the PR. LGTM overall. Left two comments below.
flink-ml-lib/src/main/java/org/apache/flink/ml/feature/binarizer/Binarizer.java
Show resolved
Hide resolved
weibozhao
force-pushed
the
FLINK-29011
branch
3 times, most recently
from
f7e4916 to
2fc9f28
Compare
zhipeng93
reviewed
Aug 30, 2022
zhipeng93
reviewed
Aug 30, 2022
weibozhao
force-pushed
the
FLINK-29011
branch
2 times, most recently
from
d511d75 to
eba7c26
Compare
Contributor
|
Thanks for the update. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Add Transformer of Binarizer in FlinkML.
Brief change log
Does this pull request potentially affect one of the following parts:
Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @public(Evolving): (yes)
Does this pull request introduce a new feature? (yes)
If yes, how is the feature documented? (Java doc)