[FLINK-29043] Reduce overhead for non-feedback HeadOperator mails #147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Improve the performance of Flink ML iteration mechanism by reducing the overhead on HeadOperator.
While #144 has reduced the overhead brought by
HeadOperator.endInput(), it is discovered that the implementation has only reduced the overhead ofMails related to feedback edge. The other mails, like operator events, still need to wait until timeout before they are able to be processed, which is equivalent toThread.sleep(timeout). Thus we need to improve the implementation in #144 to reduce the overhead for all mails theHeadOperatorwould receive.The performance improvement brought by this PR on the unit tests of algorithms with iterations is as follows.
[1] https://github.com/apache/flink-ml/runs/7966776640?check_suite_focus=true
[2] https://github.com/apache/flink-ml/runs/7968880728?check_suite_focus=true
Brief change log
HeadOperator.MailboxExecutorWithYieldTimeoutwith a timer to schedule the timeout event.Does this pull request potentially affect one of the following parts: